search

chargebee / chargebee-typescript

Typescript library for the Chargebee API.
https://apidocs.chargebee.com/docs/api?lang=typescript
MIT License
23 stars 15 forks source link

fix: move `@types/q` to dependencies. #39

Open b-steel opened 1 year ago

b-steel commented 1 year ago

Since @types/q is listed in devDependencies then it is not installed when chargebee-typescript is installed. Projects that use chargebee-typescript can have problems with the typescript compilation without this package and it can be very frustrating to debug.

The RequestWrapper components .request() method returns a Promise that is imported from the q package. Since chargebee-tyepscript is exporting this interface/type from the @types/q package it should be listed as a dependency, not a devDependency.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ihmpavel commented 4 months ago

Looks like this has been added to 2.34.0 https://github.com/chargebee/chargebee-typescript/commit/8a4e9fa1a886565705650ac72120aa0842a73dc0#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R23-L27 and it totally breaks typings https://github.com/chargebee/chargebee-typescript/issues/55