search

chargify / chargify_api_ares

A Chargify API wrapper for Ruby using ActiveResource
http://chargify.com
MIT License
161 stars 96 forks source link

Remote tests are running by default #132

Closed wsmoak closed 5 years ago

wsmoak commented 8 years ago

To reproduce:

  1. git clone git@github.com:chargify/chargify_api_ares.git
  2. cd chargify_api_ares
  3. (optionally, add a .ruby-version file if using rbenv)
  4. bundle exec rspec

Result:

$ bundle exec rspec
WARNING: VCR's FakeWeb integration is deprecated and will be removed in VCR 3.0.

ERROR: Make sure a remote.yml file exists at ./spec/remote/remote.yml

The remote tests are running by default, and they should not be.

spec/spec_helper.rb includes config.filter_run_excluding :remote => true however it still tries to run the remote tests.

According to https://relishapp.com/rspec/rspec-core/v/2-2/docs/filtering/exclusion-filters it looks like the top-level describes in spec/remote/remote_spec.rb need to be:

describe "The Test...", :remote => true do

wsmoak commented 8 years ago

It appears that rake test is the official way to run the tests, however this is not documented, and someone new to the project may type rspec or bundle exec rspec expecting it to work.