search

chargify / chargify_api_ares

A Chargify API wrapper for Ruby using ActiveResource
http://chargify.com
MIT License
161 stars 96 forks source link

Chargify::Invoice#find_by_invoice_id returns incorrect invoice #141

Open carsonreinke opened 7 years ago

carsonreinke commented 7 years ago

😕

Chargify::Invoice.find_by_invoice_id(1138429) returns Invoice #1158745. Looking at ActiveResource log, it sends this GET: https://example.chargify.com:443/invoices.xml?id=1138429. This should be obviously: https://example.chargify.com:443/invoices/1138429.xml.

This is pretty badly broken.

carsonreinke commented 7 years ago

I guess not sure why I was not using just #find instead. Not sure if adding this method was by mistake, but really it does nothing at all. I would suggest removing it completely or aliasing #find. If this suppose to do something else, please let me know.