chargify / chargify_api_ares

A Chargify API wrapper for Ruby using ActiveResource
http://chargify.com
MIT License
160 stars 95 forks source link

Allows canceling a subscription with all supported attributes #161

Closed blakeprudhomme closed 6 years ago

blakeprudhomme commented 7 years ago

Supported Attributes:

API reference https://reference.chargify.com/v1/subscriptions-cancellations#cancel-subscription-2

Closes #160

wsmoak commented 7 years ago

Thanks! We're actually checking on whether cancellation_method was meant to be exposed as an input attribute, so once we get that sorted out we can take a look at this.

blakeprudhomme commented 7 years ago

Ok that makes sense. It's not really needed for us, I just added it while I was making the update since the API exposed it.

I noticed that the API says: cancellation_method : null or string

but have seen "cancellation_method"=>0, returned with the subscription object

wsmoak commented 6 years ago

Sorry for the delay on this and the misleading docs! We've updated them to remove the cancellation_method as an input attribute https://reference.chargify.com/v1/subscriptions-cancellations/cancel-subscription

It's present in the output, but it isn't something you can set.

If you'd like to update this to remove the use of cancellation_method in the input, we can review it, or if you don't want to spend more time time on it we can just go ahead and add this separately.

Thanks again for your work on it!

YesThatAllen commented 6 years ago

And for those who need to be able to set the method, so we can make use of your new churn metrics? 🙏

blakeprudhomme commented 6 years ago

@wsmoak cancellation_method removed. 👍