chargify / chargify_api_ares

A Chargify API wrapper for Ruby using ActiveResource
http://chargify.com
MIT License
161 stars 96 forks source link

ActiveResource 3.2.16 dependency? #91

Closed supairish closed 9 years ago

supairish commented 9 years ago

Hello!, Is there a specific reason you have ActiveResource locked to version 3.2.16? This version of ActiveResource depends on ActiveModel 3.2.16. Which means I can't use this gem in a Rails 4 app.

# Runtime Dependencies
  s.add_runtime_dependency('activeresource', '~> 3.2.16')
In Gemfile:
    chargify_api_ares (~> 1.1.0) ruby depends on
      activeresource (~> 3.2.16) ruby depends on
        activemodel (= 3.2.16) ruby

    rails (~> 4.0.10) ruby depends on
      activerecord (= 4.0.10) ruby depends on
        activemodel (4.0.10)
jeremywrowe commented 9 years ago

@supairish The only reason why we have the gem locked to that version of active resource (that I know of) is that we just haven't done a lot of testing of it in a rails 4 environment. We have been slowly creeping up the version number, but If I get a chance I will test it out in a rails 4 environment and if everything good I will consider bumping it. I do know that active resource has seen some api changes in recent versions > 4.

Thanks for reaching out and I will try to get you a firm yes or no on the upgrade as soon as I have time.

jonathansimmons commented 9 years ago

For what it's worth we've been using this on Rails 4.1.5 for some time without issue. We are awaiting the dependency removal to be able to use features released since 1.1.0.

jeremywrowe commented 9 years ago

good to know @jonathansimmons I will do some quick validation myself and if everything looks good i'll gladly remove the restriction.

jeremywrowe commented 9 years ago

Checkout version 1.2.1!

supairish commented 9 years ago

Thanks!