charinev / opnc

CharIN Open Plug&Charge Protocol (OPNC)
Creative Commons Attribution Share Alike 4.0 International
18 stars 8 forks source link

setSignedContractDataAsDefault is not compliant with STF core rule "freedom of choice" and must be removed #58

Open guillaumeFRANCOIS opened 10 months ago

guillaumeFRANCOIS commented 10 months ago

The issue is already described in this previous issue https://github.com/charinev/opnc/issues/40 that was closed but the discussion on this point is still pending (status was "Needs to be done at the Governance level (STF)").

If it wasn't settled yet, shouldn't we remove the WS setSignedContractDataAsDefault in first version and add it after it was validated ?

steffenrhinow commented 10 months ago

The settlement was that this is actually not restricting the "freedom of choice" -> it is enabling the freedom of choice. That means we should keep it in the initial version.

MKeCharIN commented 10 months ago

Has been discussed and if there shall be a change, it needs to be discussed in a bigger scale again. So far, not limitation indicated.

thesimmermon commented 9 months ago

I don't see anywhere in the specification how the default contract is set across ecosystems. It is possible for a PCID to match to contracts in multiple ecosystems.

How do you set the default across multiple ecosystem and what does it mean to have a default?

It appears that in this protocol multiple signedContractResponse objects are returned in response to the GetSignedContractDataByCertificateInstallationReq. How does setting the default affect this list? I don't see anything in here that indicates that any particular certificate is the default. If that's the case, what is the point of setting the default?

steffenrhinow commented 9 months ago

The Project from elaad showed last 2022 that the contract shall be located in the ecosystem where the OEM Prov Cert is located. As the OEM Backend is the only one which can set the default contract, no broadcast is needed

The GetSignedContractDataByCertificateInstallationReq is prepared for ISO15118-20 with responding with multiple Packages. In -2 just one package can be delivered - to still allow multi-contract handling, the default flag is used to stear the desired contract installation of the customer