Replace sendJavascript with cordova.channel

chariotsolutions / phonegap-nfc

PhoneGap NFC Plugin

MIT License

706 stars 556 forks source link

Replace sendJavascript with cordova.channel #263

Closed martin-rueegg closed 6 years ago

martin-rueegg commented 7 years ago

Should solve #196 (see comment) and #249. Please test and comment.

don commented 7 years ago

@martin-rueegg generally I think this approach will work

Can you adjust the phonegap-nfc.js so it doesn't use the spread operator? This need this plugin to work with projects that don't have a compile step.

https://github.com/BristolPound/phonegap-nfc/blob/1de9c1c49cb4c4cd8d545af63e32820bcf70d009/www/phonegap-nfc.js#L769-L781

don commented 6 years ago

@martin-rueegg thanks for this pull request. I implemented the channel but kept all the existing Javascript events in place for now so the other platforms can keep working without changes. Fixed by #323.