search

chariotsolutions / phonegap-nfc

PhoneGap NFC Plugin
MIT License
706 stars 555 forks source link

Fix issue AndroidManifest.xml #372

Closed LuisEGR closed 4 years ago

LuisEGR commented 4 years ago

When using with ionic 4, there is a preference:

and it gets merged into the AndroidManifest.xml, so when you try to install this plugin, there is a conflict and an error with the xml parsing:

Error: Unable to graft xml at selector "/manifest/uses-sdk" from "platforms\android\app\src\main\AndroidManifest.xml" during config install at ConfigFile_graft_child [as graft_child]

This fix removes the extra configuration setting for the AndriodManifest so it doesn't cause conflict.

odai-alali commented 4 years ago

Hi @don ,

Are you still maintaining this plugin? This merge request is required for this plugin to work with the cordova@9.0.0 and cordova-android@^8.0.0 uses-sdk is not allowed anymore in the manifetst. These values must be included in the gradle options.