tigoe
commented
11 years ago On Mar 3, 2013, at 8:58 PM, Don Coleman wrote:
Comparing types to RTD_* constants is clunky since arrays can't be compared.
This change will make the JavaScript more convenient
Converting the constants to Strings is OK, since most constructors now take Strings or [] and convert appropriately.
Exactly my thinking.
The native implementations probably don't need to change.
Sweet.
I haven't see a case where Type is not a String. Need to check the specs, but it would be nice if record.type and record.id could be strings and only payload would be a byte array.
I don't see any reason why not. Will do a double check on the spec tonight.
/cc @tigoe
— Reply to this email directly or view it on GitHub.
don
Comparing types to RTD_* constants is clunky since arrays can't be compared.
This change will make the JavaScript more convenient
Converting the constants to Strings is OK, since most constructors now take Strings or [] and convert appropriately.
The native implementations probably don't need to change.
I haven't see a case where Type is not a String. Need to check the specs, but it would be nice if record.type and record.id could be strings and only payload would be a byte array.
/cc @tigoe