Breaking changes from Kafka 2.8.0

charithe / kafka-junit

JUnit rule for spinning up a Kafka broker

Apache License 2.0

105 stars 45 forks source link

Breaking changes from Kafka 2.8.0 #61

Closed bgeisberger closed 3 years ago

bgeisberger commented 3 years ago

Unfortunately, this library is not compatible with Kafka 2.8.0 In a recent commit (https://github.com/apache/kafka/commit/8f063c15da51d77a40aa63f110e48c5eeeaf5dfc), KafkaServerStartable got removed, which breaks the EphemeralKafkaBroker.

charithe commented 3 years ago

Thanks for the info. It was inevitable that the Kafka internals would change at some point and break this library. I currently don't have the time to keep up with Kafka updates so there probably won't be a new release of kafka-junit that would support Kafka 2.8.0 and above. Feel free to fork the repository and add the functionality. I'll be happy to add a link to the README to point people to that fork.

TheKnowles commented 3 years ago

@charithe I opened a pull request for this. I updated to kafka 2.8.0.

charithe commented 3 years ago

Brilliant! Thank you.