search

charkost / prosopite

:mag: Rails N+1 queries auto-detection with zero false positives / false negatives
Apache License 2.0
1.53k stars 46 forks source link

Make `Prosopite.resume` an alias of `Prosopite.scan` #37

Closed ghiculescu closed 2 years ago

ghiculescu commented 2 years ago

This simplifies the implementation a little. I came across this when I accidentally wrote this:

Prosopite.resume
Prosopite.finish

and it crashed since I'd never called scan!

Turns out scan and resume basically do the same thing.

charkost commented 2 years ago

Hi @ghiculescu, thanks for the PR. Could you rebase to origin/main & reduce the change to one commit? Currently it is not mergeable.

ghiculescu commented 2 years ago

@charkost done!