Make sure scan has properly started in scan? check

charkost / prosopite

:mag: Rails N+1 queries auto-detection with zero false positives / false negatives

Apache License 2.0

1.53k stars 46 forks source link

Make sure scan has properly started in scan? check #51

Closed charkost closed 2 years ago

charkost commented 2 years ago

The previous check was not sufficient since it could by mocked by Prosopite.resume resulting to unexpected exceptions:

Prosopite.resume
Prosopite.scan
Prosopite.finish

NoMethodError: undefined method `each' for nil:NilClass from gems/prosopite-1.1.3/lib/prosopite.rb:84:in `create_notifications'

Credits to @iridakos for raising the issue.