Middleware::Rack: don't rely on `Prosopite.scan`'s block execution

charkost / prosopite

:mag: Rails N+1 queries auto-detection with zero false positives / false negatives

Apache License 2.0

1.53k stars 46 forks source link

Middleware::Rack: don't rely on `Prosopite.scan`'s block execution #75

Closed dhruvCW closed 10 months ago

dhruvCW commented 11 months ago

Change the rack middleware to no longer use the Prosopite.scan's block execution syntax. This bring it inline with the sidekiq middleware.

charkost commented 11 months ago

fixes any issues caused by the block execution process

Could you elaborate?

dhruvCW commented 11 months ago

fixes any issues caused by the block execution process

Could you elaborate?

we noticed that the Prosopite.pause call doesn't seem to pause the scanning. This PR just minimizes the variables for us as we debug why pause doesn't seem to work. I edited the description since it's not actually fixing anything.