search

charkour / react-reactions

😲 Create custom reaction pickers and counters or use your favorites!
MIT License
76 stars 16 forks source link

Seems like a icon is missing #120

Closed gj1118 closed 2 years ago

gj1118 commented 2 years ago

Describe the bug It seems that the icons are not getting rendered. I ran the examples and I am seeing this image In my app as well, I am seeing this icon instead of the usual "smiley" icon .. Is this expected? image

To Reproduce Steps to reproduce the behavior:

  1. Install the package
  2. Import as such import { SlackCounter } from "@charkour/react-reactions";
  3. Use as such <SlackCounter />
  4. You will observe that there are rectangles all over instead of the icons

Expected behavior An icon should appear where the user needs to click. RIght now a rectangle appears.

Desktop (please complete the following information):

gj1118 commented 2 years ago

Apologies this was my bad. I have got it working.

Apologies for the spam.

charkour commented 2 years ago

All good. Glad is it working!

michaelshum commented 2 years ago

@gj1118 How did you resolve this? I tried downloading the required fonts into public/, but for any sub-pages I get a GET http://localhost:3000/{sub_dir_name}/fonts/slack-icons-Regular.woff net::ERR_ABORTED 404 (Not Found), since the page is fetching from the subdir... what's the right way to handle the fonts?