search

charkour / react-reactions

😲 Create custom reaction pickers and counters or use your favorites!
MIT License
76 stars 16 forks source link

Selector and Counter Bundlize as one #144

Open c0ncentus opened 2 years ago

c0ncentus commented 2 years ago

Is your feature request related to a problem? Please describe.

Add one type of Component, One for rule the all ! Exemple <Bundlize counter={} Selectors={} events={(e)=>{}} />

Describe the solution you'd like it would be appreciable to have this instantly without managing events/state all the times image it would make sens in <Bundlize counter={} Selectors={ /> events links are bound ...

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Component are seperate UI and visual concept, but would make sens to make as one for user commun use !

charkour commented 2 years ago

Hey @c0ncentus,

Thanks for the great suggestion! And thank you for using the package for a long time.

To clarify, would you like a component with a counter and selector so that the state can be shared between the two? Currently, there has to be a parent component that manages the state and shares it between the two?

I like this idea, but it might take longer to implement.

c0ncentus commented 2 years ago

"To clarify, would you like a component with a counter and selector so that the state can be shared between the two?"

Yes completely.

"Currently, there has to be a parent component that manages the state and shares it between the two?"

Yes currently, it is ! thats why my suggestion.

an alternative use 

<Bundle>
    <Counter/>
    <Selector/>
</Bundle>

But not sure if it's work. But if only 1 configuration is available (Counter and Selector) will be fine with events.

I'm ok with the time. Thanks to maintain this awesome UI features !

charkour commented 2 years ago

Thanks for the quick response!

I like the <Bundle> as a parent so that we can use Context. The <Bundle> can be a provider.

I'll come up with an API and ask for your feedback in about a week's time.

charkour commented 2 years ago

Hey @c0ncentus,

I like the simple API example you provided. I haven't had time yet to work on it so I can't guarantee when it will be released. You are welcome to try making a PR that adds this feature.