search

charles-001 / dolphie

Your single pane of glass for real-time analytics into MySQL/MariaDB & ProxySQL
https://pypi.org/project/dolphie/
GNU General Public License v3.0
651 stars 40 forks source link

Mariadb 10 compatibility #25

Closed gregorg closed 1 year ago

charles-001 commented 1 year ago

Hi @gregorg - thanks for looking into adding support for MariaDB! Is that really all that's needed? Just that 1 query? Everything else works? If so, that's awesome.

I think instead of determining if a host is MariaDB by self.host_distro.startswith("MariaDB"), we create a variable similar to is_host_rds called is_host_mariadb and use that. That'll simplify things for future MariaDB incompatibilities. Can you include that?

gregorg commented 1 year ago

ok, did it. I tried every panel and don't see any exception throwed. Some values can be N/A and should be handled but I'll do that later if necessary.

charles-001 commented 1 year ago

Awesome! Thank you.