search

charles-001 / dolphie

Your single pane of glass for real-time analytics into MySQL/MariaDB & ProxySQL
https://pypi.org/project/dolphie/
GNU General Public License v3.0
589 stars 36 forks source link

Mention MariaDB support in README #60

Closed ottok closed 4 months ago

ottok commented 4 months ago

Dolphie supports MariaDB and has it in e.g. DataTypes.py. This is however not evident to a new user as the README.md didn't mention anything about MariaDB. Fix it with a couple of mentions of MariaDB.

charles-001 commented 4 months ago

Hi @ottok - thank you for the spelling fixes! While Dolphie does have mentions of MariaDB in its code, the support for it is very minimal. I do not test changes for it and as MariaDB keeps diverging from MySQL, Dolphie will become even more incompatible unless someone decides to contribute.

Are you currently using Dolphie with MariaDB? If so, what version and does everything work for you?

ottok commented 4 months ago

I only recently discovered Dolphie but yes, I am using it with MariaDB and have not found any issues.

dolphie.webm

How about you merge this now, and if you later get reports that MariaDB does not work, you update/remove it from the README?

Considering most Linux distributions have replaced MySQL completely and have only shipped MariaDB for years, you might be missing out on a large user base if you don't mention MariaDB anywhere. Ideally it can even be a self-fulfilling thing - if somebody who uses MariaDB notices that something in Doplhie does not work, they might submit a PR to fix it. If you don't mention MariaDB anywhere, people might not even try..?

charles-001 commented 4 months ago

It's more along the lines of if I state I officially support it, people will send in requests for MariaDB-specific things ;) I personally don't use MariaDB so I don't have a vested interest like I do with MySQL, but I'm all for contributions if people want to help support it! With that said, I'll merge this PR since MariaDB seems to be currently working with no issues. Thank you for bringing this to my attention!