codepathreview
commented
9 years ago awesome app! The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:
- follow Github markdown syntax, lets you check off checkboxes https://github.com/blog/1375%0A-task-lists-in-gfm-issues-pulls-comments
- https://github.com/charles-dong/Rotten-Tomatoes/blob/master/Rotten%20Tomatoes/MoviesViewController.m#L130 background block is unnecessary here and incorrect: sendAsynchronousRequest will already happen on a background thread, and the whole block is included. Any interface update should happen on the main thread
- Nice code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
- MoviesController.movies You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
- In future homework, we will cover how to implement models that can deserialize from an NSDictionary. It might be interesting to check out the Mantle project for a lightweight ORM.
- Your custom Movie cell should have a property called
movie. In the custom setter ofmovie, you should configure the various labels and images. This decouples your custom cells from the table view controllers. - Nice work setting up the proper modes for the images so that they are not stretched.
- Nice work implementing the error message on network failure.
In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.
-- dirk
charles-dong
/cc @codepathreview