search

charles-lunarg / vk-bootstrap

Vulkan Bootstrapping Iibrary
MIT License
818 stars 82 forks source link

warning: declaration shadows a field of 'vkb::PhysicalDevice' #280

Closed dortamiguel closed 5 months ago

dortamiguel commented 6 months ago

I'm getting this warning when including the VkBootstrap header

warning: declaration shadows a field of 'vkb::PhysicalDevice'

And it comes from this template

include/VkBootstrap.h:545:78: warning: declaration shadows a field of 'vkb::PhysicalDevice' [-Wshadow]
    template <typename T> bool enable_extension_features_if_present(T const& features) {
                                                                             ^
include/VkBootstrap.h:505:30: note: previous declaration is here
    VkPhysicalDeviceFeatures features{};

https://github.com/charles-lunarg/vk-bootstrap/blob/main/src/VkBootstrap.h#L545

Is it fine to fix it? Somehow I can't make clang to ignore this warning