search

charles-river-analytics / figaro

Figaro Programming Language and Core Libraries
Other
757 stars 151 forks source link

Algorithms are registered on the universe but never deregistered #658

Open bruttenberg opened 7 years ago

bruttenberg commented 7 years ago

When a ProbQueryAlgorithm is created, it is registered on the universe, but when a kill is issued, it is never deregistered. This is a problem when you have many nested inference algorithms. This really should be done at the algorithm level automatically for every algorithm created.

wkretschmer commented 7 years ago

Is this a duplicate of #596?

bruttenberg commented 7 years ago

Indeed, this is a repeat. So this was never fixed in Algorithm, correct?

From: William Kretschmer [mailto:notifications@github.com] Sent: Wednesday, January 4, 2017 4:02 PM To: p2t2/figaro figaro@noreply.github.com Cc: Brian Ruttenberg bruttenberg@cra.com; Author author@noreply.github.com Subject: Re: [p2t2/figaro] Algorithms are registered on the universe but never deregistered (#658)

Is this a duplicate of #596https://github.com/p2t2/figaro/issues/596?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/p2t2/figaro/issues/658#issuecomment-270485435, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFJOJUB11yLLKJsv_5XoVMFJJtb6UNsiks5rPAjKgaJpZM4La0VM.

wkretschmer commented 7 years ago

No, we haven't fixed this yet.