Currently, isShureq only checks whether the cluster has a vowel, which incorrectly labels clusters with a vocal sheva (e.g. the third cluster of מְצַוְּךָ) and clusters with a preceding vowel (e.g. the second cluster of גֵּוּ) as shureqs.
This is important because if DAGESH_CHAZAQ is set to false in hebrew-transliteration, then isShureq is called to determine whether to transliterate the cluster as a SHUREQ. For example, currently:
Currently,
isShureqonly checks whether the cluster has a vowel, which incorrectly labels clusters with a vocal sheva (e.g. the third cluster of מְצַוְּךָ) and clusters with a preceding vowel (e.g. the second cluster of גֵּוּ) as shureqs.This is important because if
DAGESH_CHAZAQis set tofalsein hebrew-transliteration, thenisShureqis called to determine whether to transliterate the cluster as aSHUREQ. For example, currently:where they should be
"gēw"and"mǝṣawǝkā", respectively, to match their versions withDAGESH_CHAZAQset totrue(i.e."gēww"and"mǝṣawwǝkā").I also added some tests, with a few of the example words taken from these Wikipedia pages: [1] [2]