charlesLoder / havarotjs

A Typescript package for getting syllabic data about Hebrew text with niqqud.
https://www.npmjs.com/package/havarotjs
MIT License
12 stars 6 forks source link

silluq not recognized as an accent? #164

Closed bdenckla closed 4 months ago

bdenckla commented 4 months ago

When I entered "לַֽיהֹוָֽה׃" I was surprised to get the suggestion to include accents:

image

I thought that by including the sof pasuq mark I would have given it enough informatio to realize that at least one of those two Unicode METEG code points represented silluq rather than gaʿya. There is a separate, haunting challenge, which is to figure out which one is the silluq and which one is the gaʿya but I think only perhaps one in perhaps 10,000 times will it be wrong to just assume that the last one is the silluq.

charlesLoder commented 4 months ago

Closing this issue and recreating it on the web app repo.

There is a separate, haunting challenge, which is to figure out which one is the silluq and which one is the gaʿya but I think only perhaps one in perhaps 10,000 times will it be wrong to just assume that the last one is the silluq.

In this package, I define a silluq in Cluster.hasSilluq by checking if the next Cluster is a sof pasuq; it may not be 100% correct, but like you indicated, it is almost always correct.

https://github.com/charlesLoder/havarotjs/blob/306ed6f17ca6c2414b569a7e653adaccda9204de/src/cluster.ts#L345-L362