getPort.php

[frju365]

I tried something, surely unfinished. I don't know how to manipulate the .out of the function. You use "$response" but can you explain how I can manipulate the echo of the function ?

fixes #20

[charlesabarnes]

I recommend checking out the code for the blacklist. It built the object and spit it out all at once

[frju365]

ok. I will see that tomorrow... 3 am in my timezone ;)

[frju365]

ok. I try something which is quite the same... as I just removed useless class and just check if ip or domain was correctly set. Not tested if it worked or not.

[frju365]

for the choice of the Port to check, we can of course do a discussion. I can add more. It's just to not write 1000 lines on the page ;)

edit : I just download every source, to avoid repeatedly do requests to google servers.

[charlesabarnes]

Beyond the external request, is there any real benefit from moving away from the CDN?

[frju365]

In fact, there are different reason (it's only my point of view... :) ) :

• If there is a new version we won't need to change code, but only the files which are in css/ and javascript/
• 2d reason : each time you send a request to google servers, and even if it's set to "anonymous", google gets your ip, at least ip from the server... which is quite bad, everything is centralized.

[charlesabarnes]

Bootstrap isn't by Google, it is a framework developed by twitter, and the CDN is served by Stackpath. Keeping the CDN in use is actually decentralizing it so the load isn't being put on your own personal CDN. This helps reduce the cost of hosting and reduces the host's server load.

[frju365]

ok. Well anyway, it was not the object of the PR ;) For privacy use, most of servers use their own bootstrap css files... The CDN hosters track websites, which is not a really good feature. Most of the website which care of privacy and data use their own files.

[frju365]

Is it ok like that ?

[frju365]

Do you have an idea what I did wrong ?

[frju365]

It works... finally (I forgot I had this PR pending). But I've still a problem with the title. It's still undefined... but strange as I added it to the main.js ... Do you have an idea how I can correct it ?

[charlesabarnes]

Sorry I've been so unresponsive. I'll take a look tonight

[frju365]

Don't worry. Well, understanding Javascript here is quite difficult. I didn't understand why it didn't work. ;) Now I understand better even if there are some part of the code which are still weird for me like the title. I didn't see a limited number of "case" in main.js, but it's perhaps my error ?

[charlesabarnes]

I'll check this out this weekend. can you add screenshots of it working?

[frju365]

Well, finally, it's ok. I get the title. Surely a cache I had in my browser. So, the PR is ready for final review. Wait 2 sec : I will add screenshot ;)

[frju365]

For this screenshot, I just changed the title in the index.html.

Perhaps in the future, I will try to add title, because in fact, here there is no title.

[frju365]

@charlesabarnes : Ok, done.

[frju365]

Sometimes it say ports is closed but are open... Perhaps increase the time in the function (to try more time) ? Try and give feedbacks... perhaps it's just cache which is the problem.

[charlesabarnes]

In the future I will want to add the option to check custom ports. LGTM