Closed ferchinas closed 2 years ago
Hello,
Thank you for the PR, and for helping to improve OSFS!
The 8+3 length was originally chosen to conform to the old DOS format: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/18e63b13-ba43-4f5f-a5b7-11e871b71f14. That was an arbitrary choice, but I don't really want to encourage people to change it: the presence of an OSFS header at the start of your memory is currently a promise that it'll conform to the format as specified. If people start changing filename sizes, that's no longer true.
However, I don't mind using a const variable in the code so that power users can alter it if they really want to: I'd just rather not advertise this in the readme.
I'd be happy to accept this PR with those tweaks! I'll leave a couple of comments on the code too.
Hi Charles, Thank you very much for your library, I have been playing with it these days integrating it with JChristensen / extEEPROM and bblanchon / ArduinoJson to store json files in my eeprom memory.
I apologize if I have not made the pull request flow correctly, it is the second I have done in my life. Please tell me if I did something wrong.
All the best
You're very welcome! I hope it helps you out.
The PR looks good to me: I'm just tweaking it to put the default filename length back to 11 chars otherwise it would break people's existing installations.
Change the hard-coded maximum character size in the filename from 11 to a constant variable