search

charlesdaniels / bitshuffle

BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

TravisCI should test setup.py using virtualenv #29

Closed charlesdaniels closed 6 years ago

charlesdaniels commented 6 years ago

What it says on the tin. Just a basic sanity check. Something like python2 ./setup.py install, then /usr/local/bin/bitshufle --version should exit nonzero. The same for Python 3 would be nice as well, although I don't see a clean way to uninstall it after installing it the first time... could use pythonX -m bitshuffle.bitshuffle I suppose, rather than /usr/local/bin.

charlesdaniels commented 6 years ago

The implementation I have now requires the use of sudo. This seems like something that could maybe be done with a virtualenv? I'm not familiar enough with virtualenvs, so I need to dig into that a bit more.

charlesdaniels commented 6 years ago

Tests are implementing and passing as of 0c0f1a4ec1cfb7bb31439a00be1ed97f8ec2cfc6. Leaving this open until the virtualenv thing is investigated.

jyn514 commented 6 years ago

This ended up being a lot easier than I expected; all you do is replace python setup.py install with pip install .

jyn514 commented 6 years ago

Addressed in https://github.com/charlesdaniels/bitshuffle/pull/52, waiting on a review to merge