search

charlesdaniels / bitshuffle

BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Rewrite tests in Python #43

Open jyn514 opened 6 years ago

jyn514 commented 6 years ago

Currently, unit tests and smoketests are written in Bash. This prevents them from being run in AppVeyor. Furthermore, the tests are in need of some rewriting (since tests NOT involving temp files require significant code duplication).

I propose we fix both problems at once by rewriting existing tests in Python.

charlesdaniels commented 6 years ago

There was some discussion on this matter off of GitHub.

I am not opposed to the idea, although running end-to-end tests in Python can be tricky because you have to use subprocess. Another option to consider for the end-to-end tests would be PowerShell, as that would allow the tests to run on Windows, macOS, and Linux, although it would also preclude them from running on BSD, Solaris, AIX, etc, so I suppose Python is ostensibly preferable.

Furthermore, the tests are in need of some rewriting (since tests NOT involving temp files require significant code duplication).

We can always abstract out duplicated code into a function, and source the function like we do realpath, assuming we stick with shell scripts.

jyn514 commented 6 years ago

Does Linux have a powershell implementation?

charlesdaniels commented 6 years ago

It does. Even an official PPA and everything.

This email was sent from my smartphone.

On Mar 1, 2018, at 08:30, Joshua Nelson notifications@github.com wrote:

Does Linux have a powershell implementation?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.