Closed jyn514 closed 6 years ago
Agreed. This looks like the right thing to do.
This email was sent from my smartphone.
On Dec 22, 2017, at 16:13, Joshua Nelson notifications@github.com wrote:
We specifically preclude unicode support in encode_packet with the line data = data.decode(encoding="ascii"). Since unicode is ascii-compatible, this should be as simple as changing encoding="ascii" to encoding="unicode".
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Added in https://github.com/charlesdaniels/bitshuffle/commit/7330dede8969f92fb814f24a7a737e2b152786ec, along with unit test
We specifically preclude unicode support in
encode_packet
with the linedata = data.decode(encoding="ascii")
. Since unicode is ascii-compatible, this should be as simple as changingencoding="ascii"
toencoding="unicode"
.