search

charlesdaniels / bitshuffle

BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Add Unicode support #45

Closed jyn514 closed 6 years ago

jyn514 commented 6 years ago

We specifically preclude unicode support in encode_packet with the line data = data.decode(encoding="ascii"). Since unicode is ascii-compatible, this should be as simple as changing encoding="ascii" to encoding="unicode".

charlesdaniels commented 6 years ago

Agreed. This looks like the right thing to do.

This email was sent from my smartphone.

On Dec 22, 2017, at 16:13, Joshua Nelson notifications@github.com wrote:

We specifically preclude unicode support in encode_packet with the line data = data.decode(encoding="ascii"). Since unicode is ascii-compatible, this should be as simple as changing encoding="ascii" to encoding="unicode".

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jyn514 commented 6 years ago

Added in https://github.com/charlesdaniels/bitshuffle/commit/7330dede8969f92fb814f24a7a737e2b152786ec, along with unit test