Make hash tests flexible for spec changes

charlesdaniels / bitshuffle

BSD 3-Clause "New" or "Revised" License

5 stars 0 forks source link

Make hash tests flexible for spec changes #50

Open jyn514 opened 6 years ago

jyn514 commented 6 years ago

Currently, there are a bunch of encoded packets in scripts/test_bad_hashes.sh. As noted here, this ties the tests to the current spec.

I would suggest introducing errors in the stream directly, for example by doing bitshuffle --encode ... | tr [:lower:] [:upper:] | ....

jyn514 commented 6 years ago

Just realized this is going to be a nightmare in bash, since there's no way to do str.split and only one of the segments can be changed. Putting this on the backburner until we implement https://github.com/charlesdaniels/bitshuffle/issues/43.