search

charlesdaniels / bitshuffle

BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Split up library and command line tool #54

Closed jyn514 closed 6 years ago

jyn514 commented 6 years ago

As suggested by Jeremy:

Consider splitting up the cli and implementation into different files Makes it a lot easier to port to other languages

Will also make https://github.com/charlesdaniels/bitshuffle/issues/39 and https://github.com/charlesdaniels/bitshuffle/issues/16 significantly easier.

jyn514 commented 6 years ago

Since bitshuffle is maturing, it will henceforth be used as a package import no matter how it is called. A wrapper script will provided for convenient sym-linking. This will simplify the current import situation considerably and relegate the uglier imports to __init__.py.

jyn514 commented 6 years ago

Any idea why the build's failing? I added the relevant file to git.

Fixed in https://github.com/charlesdaniels/bitshuffle/commit/1f96aadcab4b7b51c4046678ad09169893b10a4c, this is why I shouldn't develop on NTFS drives