search

charlesdaniels / bitshuffle

BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

`encode_file` fails if filehandle is of type bytes #61

Closed jyn514 closed 6 years ago

jyn514 commented 6 years ago

This is not a problem with the function itself so much as the implementation. In main, we should decide whether to call encode_file or encode_data depending on the type of the input.

This will help significantly with https://github.com/charlesdaniels/bitshuffle/issues/16.

jyn514 commented 6 years ago

Done in https://github.com/charlesdaniels/bitshuffle/commit/d72852193348026968063ada6ed8c34168b3f9c9