In `decode`, it should be clear that variables are indicies

charlesdaniels / bitshuffle

BSD 3-Clause "New" or "Revised" License

5 stars 0 forks source link

In `decode`, it should be clear that variables are indicies #63

Closed jyn514 closed 6 years ago

jyn514 commented 6 years ago

these variables names do not make it obvious that these values are indices. Reading file_hash, you would expect the variable to hold the hash, not the index thereof.

See https://github.com/charlesdaniels/bitshuffle/pull/60#discussion_r172040641

jyn514 commented 6 years ago

Done in https://github.com/charlesdaniels/bitshuffle/commit/5408354e4d83d4b714eb5f6acfc789e55165c3f1