Closed jyn514 closed 6 years ago
these variables names do not make it obvious that these values are indices. Reading file_hash, you would expect the variable to hold the hash, not the index thereof.
See https://github.com/charlesdaniels/bitshuffle/pull/60#discussion_r172040641
Done in https://github.com/charlesdaniels/bitshuffle/commit/5408354e4d83d4b714eb5f6acfc789e55165c3f1
See https://github.com/charlesdaniels/bitshuffle/pull/60#discussion_r172040641