search

charlesdaniels / bitshuffle

BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Wrapper not compatible with powershell #64

Closed jyn514 closed 6 years ago

jyn514 commented 6 years ago

In https://github.com/charlesdaniels/bitshuffle/commit/fb39078cd4ced5f01cc16918b8097d88b058e8b2, I transitioned to making the module directly executable, so that python -m bitshuffle would run the program instead of the previous error. For this to work with a wrapper, I changed it to a shell command: cd "$(dirname "$(realpath "$0")")" && exec python -m bitshuffle "$@". Unfortunately, sh does not exist on Windows.

jyn514 commented 6 years ago

Proposed solution: switch the test to directly execute the module (python -m bitshuffle) instead of using the wrapper. This will still leave the wrapper compatible only with UNIX systems.

This will require changing directories in the middle of a script.

jyn514 commented 6 years ago

Made this platform independent in https://github.com/charlesdaniels/bitshuffle/commit/062d067f6f08d5fd598a0ce3dc14417c8f940430. Unfortunately, Powershell is still crashing for an unknown reason.

jyn514 commented 6 years ago

Fixed in https://github.com/charlesdaniels/bitshuffle/commit/2afcba55de36a4e7eccdfa5d0ec5b77f60c68baf; I forget to remove python_bin now that we're using a wrapper