Fix background issue - Githubissues

charlesetc / feather

A shell library for OCaml

MIT License

77 stars 8 forks source link

Fix background issue #16

Closed tmarti2 closed 3 years ago

tmarti2 commented 3 years ago

This PR should fix background issues mentionned in PR #10 and issue #6 . Here I choosed to ignore exit code from background commands. State.exit (and last_exit ()) will be updated when you run either

collect_stdout
collect_lines
run

Wait for @Firobe reviews to make sure I did not do mistakes ;)

Firobe commented 3 years ago

Approved! Basically this correctly propagates the exit status within the eval tree but keeps last_exit as a means for the user to access it for now.

I'll make sure #10 is compatible with this if it is merged, it's probably better to have a smaller PR to discuss.

charlesetc commented 3 years ago

This looks great!