charleskawczynski / PlayingCards.jl

A package for representing playing cards for card games.
MIT License
14 stars 4 forks source link

Add cut and riffle #17

Open charleskawczynski opened 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #17 (c9b8792) into main (3ed113b) will decrease coverage by 16.51%. The diff coverage is 63.26%.

:exclamation: Current head c9b8792 differs from pull request most recent head 7c82f98. Consider uploading reports for the commit 7c82f98 to get more accurate results Impacted file tree graph

@@             Coverage Diff              @@
##              main      #17       +/-   ##
============================================
- Coverage   100.00%   83.48%   -16.52%     
============================================
  Files            1        2        +1     
  Lines           63      109       +46     
============================================
+ Hits            63       91       +28     
- Misses           0       18       +18     
Impacted Files Coverage Δ
src/PlayingCards.jl 100.00% <ø> (ø)
src/shuffle.jl 63.26% <63.26%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ed113b...7c82f98. Read the comment docs.

scheinerman commented 3 years ago

Hi Charlie,

I'm really not sure what I'm supposed to do here. It looks like there are some gotchas to fix. I'm ok approving so it's not me that stands in your way making progress.

Ed

charleskawczynski commented 3 years ago

I'm really not sure what I'm supposed to do here.

I requested for you to review-- to see if the changes make sense and give the expected behavior. What are the gotchas to fix? I'm in no rush to add these functions, I thought you wanted to add them 🙂

I can see that I need to add cut/riffle etc. to the documentation api. I'll do that at my lunch break.