search

charleskawczynski / PlayingCards.jl

A package for representing playing cards for card games.
MIT License
14 stars 4 forks source link

Support new MaskedDeck operations: `StatsBase.sample!`, `Base.popat!` and "`restore!`" #35

Closed charleskawczynski closed 11 months ago

charleskawczynski commented 11 months ago

This is now truly a masked deck (using a bitarray)

charleskawczynski commented 11 months ago

bors r+

codecov[bot] commented 11 months ago

Codecov Report

Merging #35 (a47d73a) into main (cbc85ba) will increase coverage by 1.64%. The diff coverage is 100.00%.

:exclamation: Current head a47d73a differs from pull request most recent head 0e96744. Consider uploading reports for the commit 0e96744 to get more accurate results

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   92.47%   94.11%   +1.64%     
==========================================
  Files           2        2              
  Lines          93      119      +26     
==========================================
+ Hits           86      112      +26     
  Misses          7        7
Files Changed Coverage Δ
src/masked_deck.jl 97.77% <100.00%> (+3.04%) :arrow_up:
charleskawczynski commented 11 months ago

bors r-

bors[bot] commented 11 months ago

Canceled.

charleskawczynski commented 11 months ago

bors r+

bors[bot] commented 11 months ago

Build failed:

charleskawczynski commented 11 months ago

bors r+

charleskawczynski commented 11 months ago

bors r+

bors[bot] commented 11 months ago

Already running a review

bors[bot] commented 11 months ago

Build failed:

charleskawczynski commented 11 months ago

bors r+

bors[bot] commented 11 months ago

Build failed:

charleskawczynski commented 11 months ago

bors r+

bors[bot] commented 11 months ago

Build failed:

charleskawczynski commented 11 months ago

popat! is undefined in Julia 1.4?? Ugh, I'm sorry, I'm dropping support for this and lower versions.

charleskawczynski commented 11 months ago

bors r+

bors[bot] commented 11 months ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.