charleskorn / kaml

YAML support for kotlinx.serialization
Apache License 2.0
515 stars 50 forks source link

Update tests to run for JS targets #584

Closed OptimumCode closed 3 months ago

OptimumCode commented 3 months ago

Hi, this PR allows running tests for JS targets.

The old version of tests had the following problems:

@sschuberth please, take a look at the PR when you have time. Thank you!

sschuberth commented 3 months ago

@sschuberth please, take a look at the PR when you have time.

Done, though I'm not sure why, as I have no approval rights on this repo 😉

OptimumCode commented 3 months ago

Thank you for your review @sschuberth! I wanted to tag @charleskorn but he does not appear in the completion list for some reason, and I accidentally tagged you instead)) don't know why - probably because it is a bit late here already)

sschuberth commented 3 months ago

I accidentally tagged you instead

No worries, I hope my review was useful still 😸

OptimumCode commented 3 months ago

No worries, I hope my review was useful still 😸

It definitely was! Thanks again

charleskorn commented 3 months ago

Thanks @OptimumCode and @sschuberth!