charlespockert / aurelia-bs-grid

Aurelia and Bootstrap powered datagrid control
MIT License
45 stars 21 forks source link

combine header and body for better aligning, ensure boolean bindable values are binded as boolean #36

Closed moshensky closed 8 years ago

moshensky commented 8 years ago

Hi,

thank you for your plugin. I'm going to use it for an almost production ready system. I'm very sorry for big red chunks of code...I have reindent it to 2 spaces as other aurelia code.

I have added ensureBooleanBindableValues() function, which checks that all @bindable values will be booleans in bind() method. Example of use keys: server-paging='true', when I don't wont to bind it to my view model and just configure it.

Also I have edited build task for SYSTEM and added sourcemaps generation for better debugging experience. I may add conditional execution of sorcemaps generation.

I have edited grid.html and have combined both tables in to one, because of missed alignment.

charlespockert commented 8 years ago

Hi @moshensky - there are a few things I can't do with this PR:

The idea is to have a scrollable table body but frozen header/filter rows so that the user doesn't lose them when scrolling. I'll be writing code to ensure the cells and headers match each other and scroll correctly

moshensky commented 8 years ago

@bandable - Than a quick note to docs would be enough about *.bind="true" if I have not missed it.

Combine header and body into one table - I've tested it with a couple of lines of css and seems to work flawless.

I will remove @bindable checks and add needed css lines for you to evaluate.