charlespockert / aurelia-bs-grid

Aurelia and Bootstrap powered datagrid control
MIT License
45 stars 21 forks source link

Can not turn off paging #50

Open jadrake75 opened 8 years ago

jadrake75 commented 8 years ago

Paging appears to be set even when using pageable="false" on the element. However this is a string yet the code in grid.js assumes a Boolean. Such that

if (this.pageable && !this.serverPaging) tempData = this.applyPage(tempData);

will evalulate to true along with the if.bind statement if you specify the pageable parameter. You need to either convert the pageable to be string based or use a different parameter for input vs. bind - see my image below of my app (I am using my own paging toolbar to control content which is why I want it off)

image

With pageable="false" in the HTML with your grid (this is a different mode where I was hoping to show the grid)

image

charlespockert commented 8 years ago

I believe that if you make it pagable.bind="false" it works correctly (but it might legitimately be a bug!)

I recall Rob Eisenberg or someone in the gitter chan mentioned something about strong type support for @bindables - I was hoping that would take care of this particular issue as if you don't use .bind the true/false value is interpreted as a string

Not heard anything since though so I may have to address this as you've suggested