charlesportwoodii
commented
7 years ago The extension was built for PHP 7.0+. Check out the opening note in the README.
Note this is extension is only compatible with PHP7+. Support for lower versions of PHP will not be considered
My Environment
BananaPi /w Bananian 16.04 r01 (kernel: 3.4.111-bananian) PHP 5.6.30-0+deb8u1 (cli)
Expected Behavior
finishing "make" command after "./configure --with-argon2" without errors
Actual Behavior
getting error message: /bin/bash ~/php-argon2-ext/libtool --mode=compile cc -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -I. -I~/php-argon2-ext -DPHP_ATOM_INC -I~/php-argon2-ext/include -I~/php-argon2-ext/main -I~/php-argon2-ext -I/usr/include/php5 -I/usr/include/php5/main -I/usr/include/php5/TSRM -I/usr/include/php5/Zend -I/usr/include/php5/ext -I/usr/include/php5/ext/date/lib -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I~/php-argon2-ext/ext/argon2/include -I~/php-argon2-ext/ext/argon2 -DHAVE_CONFIG_H -g -O2 -c ~/php-argon2-ext/argon2.c -o argon2.lo libtool: compile: cc -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1 -I. -I~/php-argon2-ext -DPHP_ATOM_INC -l~/php-argon2-ext/include -I~/php-argon2-ext/main -I~/php-argon2-ext -I/usr/include/php5 -I/usr/include/php5/main -I/usr/include/php5/TSRM -I/usr/include/php5/Zend -I/usr/include/php5/ext -I/usr/include/php5/ext/date/lib -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I~/php-argon2-ext/ext/argon2/include -I~/php-argon2-ext/ext/argon2 -DHAVE_CONFIG_H -g -O2 -c~/php-argon2-ext/argon2.c -fPIC -DPIC -o .libs/argon2.o ~/php-argon2-ext/argon2.c:10:37: fatal error: ext/standard/php_random.h: No such file or directory
include "ext/standard/php_random.h"
compilation terminated. Makefile:181: recipe for target 'argon2.lo' failed make: *** [argon2.lo] Error 1
Reproduction Steps
following your build instructions step-by-step
Output of "make test" in ext/argon2
Building without optimizations cc -std=c89 -pthread -O3 -Wall -g -Iinclude -Isrc -Wextra -Wno-type-limits src/argon2.c src/core.c src/blake2/blake2b.c src/thread.c src/encoding.c src/ref.c src/test.c -o testcase Default build argon2i v=16: OK argon2d v=16: OK argon2id v=16: OK argon2i v=19: OK argon2d v=19: OK argon2id v=19: OK Force OPTTEST=1 argon2i v=16: OK argon2d v=16: OK argon2id v=16: OK argon2i v=19: OK argon2d v=19: OK argon2id v=19: OK ./testcase Test Argon2i version number: 10 Hash test: $v=16 t=2, m=16, p=1, pass=password, salt=somesalt: PASS Hash test: $v=16 t=2, m=18, p=1, pass=password, salt=somesalt: PASS Hash test: $v=16 t=2, m=8, p=1, pass=password, salt=somesalt: PASS Hash test: $v=16 t=2, m=8, p=2, pass=password, salt=somesalt: PASS Hash test: $v=16 t=1, m=16, p=1, pass=password, salt=somesalt: PASS Hash test: $v=16 t=4, m=16, p=1, pass=password, salt=somesalt: PASS Hash test: $v=16 t=2, m=16, p=1, pass=differentpassword, salt=somesalt: PASS Hash test: $v=16 t=2, m=16, p=1, pass=password, salt=diffsalt: PASS Recognise an invalid encoding: PASS Recognise an invalid encoding: PASS Recognise an invalid salt in encoding: PASS Verify with mismatched password: PASS Decode an error message: PASS
Test Argon2i version number: 13 Hash test: $v=19 t=2, m=16, p=1, pass=password, salt=somesalt: PASS Hash test: $v=19 t=2, m=18, p=1, pass=password, salt=somesalt: PASS Hash test: $v=19 t=2, m=8, p=1, pass=password, salt=somesalt: PASS Hash test: $v=19 t=2, m=8, p=2, pass=password, salt=somesalt: PASS Hash test: $v=19 t=1, m=16, p=1, pass=password, salt=somesalt: PASS Hash test: $v=19 t=4, m=16, p=1, pass=password, salt=somesalt: PASS Hash test: $v=19 t=2, m=16, p=1, pass=differentpassword, salt=somesalt: PASS Hash test: $v=19 t=2, m=16, p=1, pass=password, salt=diffsalt: PASS Recognise an invalid encoding: PASS Recognise an invalid encoding: PASS Recognise an invalid salt in encoding: PASS Verify with mismatched password: PASS Decode an error message: PASS
Common error state tests Fail on invalid memory: PASS Fail on invalid null pointer: PASS Fail on salt too short: PASS make test 247.39s user 14.19s system 99% cpu 4:23.55 total