search

charlesrocabert / gbapy

Growth balance analysis in Python
GNU General Public License v3.0
1 stars 0 forks source link

Gathering functions in a single file #5

Closed charlesrocabert closed 1 month ago

charlesrocabert commented 2 months ago

It would be good if you gather all your functions in a single file (I see you started to do that with the script Trajectory Functions.py. It you do that, it will be easier to debug; for now your functions are duplicated in each notebook, and it is hard to find the differences.

charlesrocabert commented 2 months ago

The best is to create a script in the src folder (e.g. GBA_trajectory.py or GBA_gradient_ascent.py). You would just need to import your functions in your notebook with from GBA_gradient_ascent import *.

charlesrocabert commented 2 months ago

(it will also facilitate the conversion towards a Python package)

fumer100 commented 2 months ago

I cleaned up the code and put it into one file. My 2 trajectory functions(with and without noise) are very similar. Just the noise part is the difference between them. I also did clean up the trajectory testing notebook. The "usage instructions" and bugs are noted there. It should be easier and clearer to understand.