search

charlessoft / pyv8

Automatically exported from code.google.com/p/pyv8
0 stars 1 forks source link

Performance regression PyV8 -r498 #161

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Running a few Thug test cases I identified a huge regression in performance 
updating PyV8 from -r478 to -r498. I'm attaching just an example but can 
reproduce it with almost every Thug test case.

SVN -r498
buffer@saiph ~/thug/src $ time python thug.py -l 
../samples/misc/PluginDetect-0.7.9.html 
real    0m23.259s
user    0m23.088s
sys     0m0.152s

SVN -r478
buffer@saiph ~/thug/src $ time python thug.py -l 
../samples/misc/PluginDetect-0.7.9.html 
real    0m1.741s
user    0m1.651s
sys     0m0.059s

Original issue reported on code.google.com by angelo.d...@gmail.com on 5 Feb 2013 at 1:15

GoogleCodeExporter commented 9 years ago 
Cloud you provide a test script to reproduce it? I need debug the call stack 
later, thanks

Original comment by flier...@gmail.com on 5 Feb 2013 at 1:18

GoogleCodeExporter commented 9 years ago 
I'm currently using Thug test cases which are already ready. Please let me know 
if it could be beneficial for you a shell on a system where Thug is already 
installed so that you can play with it and test. Otherwise I can try arranging 
some smaller script but it will require more time obviously.

Original comment by angelo.d...@gmail.com on 5 Feb 2013 at 1:23

GoogleCodeExporter commented 9 years ago 
PyErr_Occurred  vs the old macro?

Original comment by ndudfi...@gmail.com on 7 Feb 2013 at 1:59

GoogleCodeExporter commented 9 years ago 
It seems caused by a bug on the Python 3.3, just redefine the macro, please 
verify it with SVN trunk code after r501, thanks

Original comment by flier...@gmail.com on 7 Feb 2013 at 2:30

GoogleCodeExporter commented 9 years ago 
Tested agains -r507 but the problem seems to be not fixed.

SVN -r478
buffer@saiph ~/thug/src $ time python thug.py -l 
../samples/misc/PluginDetect-0.7.9.html 
[..]
real    0m1.693s
user    0m1.658s
sys     0m0.041s

SVN -r507
buffer@saiph ~/thug/src $ time python thug.py -l 
../samples/misc/PluginDetect-0.7.9.html 
[..]
real    0m22.693s
user    0m22.534s
sys     0m0.142s

Original comment by angelo.d...@gmail.com on 8 Feb 2013 at 8:52

GoogleCodeExporter commented 9 years ago 
I tested against -r510 and seems like the issue is still not solved. Please let 
me know if I can help you some way spotting the regression cause.

Original comment by angelo.d...@gmail.com on 7 Apr 2013 at 9:02