charlie-haley / omada_exporter

Prometheus Exporter for TP-Link Omada Controller SDN.
MIT License
88 stars 14 forks source link

Add connected client metrics #28

Closed jamiebrynes7 closed 2 years ago

jamiebrynes7 commented 2 years ago

This PR adds a metric to track the currently connected client count.

I first looked at aggregating over the existing client metrics to derive this value.. but then realized it includes historical clients that may not be connected anymore!

charlie-haley commented 2 years ago

Could you also update the Metrics part of the README.md to document the new metric

There's a small script that will do that will generate the markdown for you, based on the contents of metrics.go but you can also update it manually if you'd like!

charlie-haley commented 2 years ago

Thanks for the PR, I'll send this out with the next release!