search

charliegriefer / my-whiskies

MIT License
2 stars 0 forks source link

Bottle images are no longer displaying on prod #162

Closed charliegriefer closed 1 week ago

charliegriefer commented 1 week ago

See here:

https://my-whiskies.online/bottle/52e8bf5c-a0d8-4d9f-aaca-d095454cdcb1

Image source is looking in the dev folder ( )

Should be prod.

Hopefully an easy fix? .env file?

Additionally, let's add some tests around ensuring that the images display.

charliegriefer commented 1 week ago

Resolved. It was an issue around how the create_app() was originally pulling in the value.

Old:

def create_app(
    config_class: Type[Config] = BaseConfig, settings_override: dict = None
) -> Flask:
    app = Flask(__name__, instance_relative_config=True)

New:

def create_app(settings_override: dict = None) -> Flask:
    config_type = os.getenv("CONFIG_TYPE", "config.DevConfig")
    config_class = DevConfig if config_type == "config.DevConfig" else ProdConfig