search

charliekassel / vuejs-datepicker

A simple Vue.js datepicker component. Supports disabling of dates, inline mode, translations
MIT License
2.61k stars 732 forks source link

1.5.4 breaks the `opened` event. #625

Open rathboma opened 6 years ago

rathboma commented 6 years ago

1.5.3 correctly fires the opened event. 1.5.4 does not. Looks like code was removed from Datepicker.vue, showCalendar

rathboma commented 6 years ago

Here is the offending commit:

https://github.com/charliekassel/vuejs-datepicker/commit/cd96cb60d5de338d751d4f324eef5c4bf30d955f

carestad commented 5 years ago

Yes, this is rather unfortunate. We rely on this event not to trigger any clicks on the underlying objects, so 1.5.4 is not possible to use.

Nathaniel-Rink commented 5 years ago

This and the closed event being broken seem like major bugs

Kovalchik8 commented 5 years ago

Still can't use 'closed' and 'opened' events.

smashdog commented 5 years ago

Still can't use 'opened' events.

triosw commented 5 years ago

Still can't use 'opened' events.

boriscy commented 5 years ago

When is it going to be fixed?

bart-1990 commented 5 years ago

I'm also waiting for a fix, the breaks some functionality of our application.

fylzero commented 5 years ago

Just FYI, this is a side-effect of the input being marked as "READONLY". Remove that tag and it fixes the emit problem. Closed/Opened/Selected all work when the input does not have a "readonly" attribute.

Still working on solving that part of the equation, but that is the source of the issue. Just thought I'd share since I'm looking into it.

fylzero commented 5 years ago

Ok, I think I figured it out. There is a prop you can pass called "typeable". That will remove "readonly" from the input field, which fixes this problem as well as the readonly formatting issues you'll have in Bootstrap 4.

What is needed: datepicker :typeable="true"

markchagers commented 4 years ago

I stumbled on this page looking for a solution for the opened and closed events not being fired. The addition of :typeable="true" to the datepicker tag doesn't have any discernable effect. (The events still do not get fired). As far as I can see, this is still broken.

yllndritb commented 4 years ago

If you need opened event for validation try using :typeable="true" and @input="<your_code_here> worked for me.

ali123plus commented 4 years ago

If you need opened event for validation try using :typeable="true" and @input="<your_code_here> worked for me.

work for me in version 1.6.2 Thanks yllndritb 👍👍

toanhuynh345 commented 3 years ago

just try to do this : <datepicker ref="dp1" @focusin.native="onfocusin"></datepicker>