search

charlierudolph / dependency-lint

Lints NPM dependencies and devDependencies
MIT License
14 stars 5 forks source link

Recognize modules used in circle.yml #28

Open kevgo opened 8 years ago

kevgo commented 8 years ago

Some modules are only used on the CI server, for example coveralls. It would be nice if this is automatically recognized. Maybe this can be generalized into dependency-lint being able to recognize any binaries in YML files?

charlierudolph commented 8 years ago

Okay that seems fine to me. Maybe a new configuration section executedModules.configurationFiles?

kevgo commented 8 years ago

Yes, that sounds perfect!

charlierudolph commented 8 years ago

How about making executedModules.shellScripts something more generic like executedModules.otherFiles?

kevgo commented 8 years ago

executedModules.executableFiles ?

charlierudolph commented 8 years ago

This issue is related to circle.yml which isn't an executableFile though.

kevgo commented 8 years ago

This seems related to #27, i.e. should be listed under referencedModules.

charlierudolph commented 8 years ago

referencedModules is searching for the name of the module, whereas executedModules is searching for the executables exposed by the module (which are not always the same)