Fix for scraping pages which reference non-existant stylesheets

charlotte-ruby / image_scraper

simple utility that pulls image URLs from a web page

MIT License

21 stars 10 forks source link

Fix for scraping pages which reference non-existant stylesheets #4

Closed syoder closed 11 years ago

syoder commented 11 years ago

I ran into an issue where it would crash when a page that I was trying to scrape referenced a stylesheet that didn't exist (server returned a 404). This fix ignores that error and continues on through the list of stylesheets.

I also fixed up tests which were failing - they're stil fairly fragile, but work at the moment.

csexton commented 11 years ago

Can we get this fix pushed to ruby gems?

mharper commented 11 years ago

+1 here too. Thanks, syoder!

jonathansimmons commented 11 years ago

+1 Thanks @syoder

caryfitzhugh commented 11 years ago

+1 me too!

johnmcaliley commented 11 years ago

I pushed this to gemcutter in v0.1.8. sorry for the delay