added unique daily options

charlotte-ruby / impressionist

Rails Plugin that tracks impressions and page views

MIT License

1.54k stars 313 forks source link

added unique daily options #221

Closed giugrilli closed 7 years ago

giugrilli commented 8 years ago

Adding the possibility of recording daily unique hits with the :daily option in the impressionist method

jgrau commented 7 years ago

@shadowed87 Thanks for the PR. I know this is an old PR but if you'd still like it merged then I'd love to help with that. Would you be up for adding a test for this functionality? And if you rebase off master then you should get a green test suite running.

jgrau commented 7 years ago

I am closing this as stale but if you're up for it please feel free to reopen, add some tests, rebase onto master (to get a valid test suite run).