search

charlotte-ruby / impressionist

Rails Plugin that tracks impressions and page views
MIT License
1.54k stars 311 forks source link

Fix #234 - Broken in latest rails version 5.1.0.beta1 #235

Closed jonhue closed 7 years ago

jonhue commented 7 years ago

Fixing Issue #234. Ensuring compatibility with Rails 5.1

jonhue commented 7 years ago

@johnmcaliley I would love if you could approve these changes, so I don't need to use a git repository as reference.

jonhue commented 7 years ago

@johnmcaliley He's alright with that. Did not pay too much attention to it, because this PR was originally meant as a quick fix of the exception in rails 5.1. Makes sense to add that, thanks for the reference!

jonhue commented 7 years ago

Ah, that snippet has already been merged with #213

jgrau commented 7 years ago

I'd like to rebase this on the new, green, master branch but it seems your branch is gone. There's other rails 5.1 PRs so I'll close this one.