Implemented patch that will add the Rails major version to the migration file

charlotte-ruby / impressionist

Rails Plugin that tracks impressions and page views

MIT License

1.54k stars 313 forks source link

Implemented patch that will add the Rails major version to the migration file #248

Closed jordanhudgens closed 7 years ago

jordanhudgens commented 7 years ago

This is to fix the issue with Rails 5.1+ that requires a major version to be declared and appended to the migration file. Similar fixes were recently added to gems such as Devise and Petergate.

I added the pull request gem version to a 5.1 project I added Impressionist to and it worked properly, while the previous version threw an error when I attempted to run the migration.

jgrau commented 7 years ago

Awesome. Thank you!