Use device detector to filter bots

charlotte-ruby / impressionist

Rails Plugin that tracks impressions and page views

MIT License

1.53k stars 311 forks source link

Open tacataca opened 5 years ago

tacataca commented 5 years ago

Change the bot filtering system to use the device detector gem.

Very straightforward swap to use a much better maintained list, however introduces an external dependancy. Also updates the rake task.

Took the liberty to also fix some issues with the CI.

rokumatsumoto commented 4 years ago

Hi @johnmcaliley,

Can you or other contributors review this PR?

Thanks!

lusinh commented 3 years ago

@tacataca You should resolve conflict